Merged
Conversation
adityaomar3
force-pushed
the
rec_button_enhancements
branch
from
e330fea to
e88196b
Compare
rmackay9
reviewed
Aug 13, 2024
adityaomar3
force-pushed
the
rec_button_enhancements
branch
from
e88196b to
b90a2eb
Compare
rmackay9
reviewed
Aug 14, 2024
rmackay9
reviewed
Aug 14, 2024
rmackay9
reviewed
Aug 14, 2024
adityaomar3
force-pushed
the
rec_button_enhancements
branch
2 times, most recently
from
231d627 to
9d07612
Compare
rmackay9
reviewed
Aug 20, 2024
rmackay9
reviewed
Aug 20, 2024
Contributor
|
I've tested this and it works great! One thing that is really impressive is how quick OpenAI can convert the audio to text. The response is nearly instantaneous |
rmackay9
requested changes
Aug 20, 2024
Contributor
rmackay9
left a comment
rmackay9
left a comment
There was a problem hiding this comment.
I've asked for a couple of non-functional changes but after that we can merge it, thanks!
adityaomar3
force-pushed
the
rec_button_enhancements
branch
from
9d07612 to
151d18c
Compare
Co-authored-by: Randy Mackay <[email protected]>
adityaomar3
force-pushed
the
rec_button_enhancements
branch
from
151d18c to
d9ee4d9
Compare
18 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR adds a push to record feature i.e. it will record the audio on mouse left key press down and stop the recording on key release.